Add loading state and error message to Deployment map

[willemarcel]

Resolves #703

@LanesGood feel free to modify the style or text.

[LanesGood]

@willemarcel I think this is looking good, but I'm seeing the error message on every campaign that doesn't have flight data. If I understand the code correctly, this should only appear if there is flight data, but it errors - is that correct? Should there be a geojson?.features?.length check combined with the geojsonError check?

EDIT
I attempted this, and then intentionally malformed the geojson for a campaign, but now I simply don't see the deployment map and there's no error message:

I also thought the loader should come first.

[willemarcel]

Actually, the only error that can happen is that we don't have a geojson for the campaign. Should we modify the text to state more clearly that it wasn't an error, but the map data for that campaign is not available?

When running locally, you need to enable throttling in your network console to see the loading map component.

[LanesGood]

@willemarcel looking again at this, I understand my confusion and think there needs to be some slight refactoring. The DeploymentMap is currently a child of the TimelineChart component. In TimelineChart the whole component is wrapped in a ReachUI Disclosure component to hide or show the timeline. This is behavior is unnecessary to wrap around the Deployment Map.

Instead, I would suggest the following:

• Rename TimelineSection to DeploymentEventsSection
• Rename Timeline directory within "Components" to DeploymentsEvents
• Within this new DeploymentEventsSection, nest the existing TimelineChart and add a new child component, DeploymentMap
• Move the existing MapErrorMsg and MapLoading components to the existing DeploymentMap to contain those concerns, and move the geojson fetching/validation logic to that as well

[LanesGood]

New message and icon for empty geojson:

Should this be called MapErrorMsg or MapEmptyStateMsg? Bigger picture, is there a need to call the error type of the useFetch hook just for empty data, or could we simply set this message if the geoJson response returns null, and use a different/more accurate message if there is a true error?

[willemarcel]

Should this be called MapErrorMsg or MapEmptyStateMsg?

I like MapEmptyStateMsg

Bigger picture, is there a need to call the error type of the useFetch hook just for empty data, or could we simply set this message if the geoJson response returns null, and use a different/more accurate message if there is a true error?

What we can do instead is check the status code of the request. If it's 404, the geojson file of that campaign was not found.