[ACA] [323618] Update managed identity image pull. #125197
Draft
+13
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@v-jaswel : Thanks for your contribution! The author(s) have been notified to review your proposed change. |
|
Learn Build status updates of commit 7a9ea32: ✅ Validation status: passed
For more details, please refer to the build report. For any questions, please:
|
|
Learn Build status updates of commit e94fee0: ✅ Validation status: passed
For more details, please refer to the build report. For any questions, please:
|
craigshoemaker
approved these changes
Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR review team: please do not review or merge this PR. This PR is part of an established workflow. Thank you.
Work item had 2 issues:
Instructions for creating container app with quickstart image were slightly outdated. Fixed.
Instructions for editing container to use image from private registry were slightly outdated. Fixed. Removed the screenshot which was outdated and can be replaced by the instructions anyway. The warning in the portal about not having admin credentials on the registry has been updated to:
"Cannot access ACR 'vjaswelcontainerregistry20241217.azurecr.io' because admin credentials on the ACR are disabled and no managed identity is assigned. Either enable admin credentials, or assign a managed identity below."
This makes the note in the article unnecessary.