feat: move unit tests from Circleci to Github actions #25570
Conversation
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #25570 +/- ##
===========================================
+ Coverage 69.67% 69.77% +0.09%
===========================================
Files 1366 1376 +10
Lines 48231 48388 +157
Branches 13304 13346 +42
===========================================
+ Hits 33604 33758 +154
- Misses 14627 14630 +3 ☔ View full report in Codecov by Sentry. |
Builds ready [a399875]
Page Load Metrics (46 ± 3 ms)
Bundle size diffs
|
Builds ready [ce18831]
Page Load Metrics (225 ± 246 ms)
Bundle size diffs
|
Builds ready [9711df5]
Page Load Metrics (70 ± 11 ms)
Bundle size diffs
|
Builds ready [6f6fbf6]
Page Load Metrics (133 ± 152 ms)
Bundle size diffs
|
Builds ready [15797c2]
Page Load Metrics (356 ± 334 ms)
Bundle size diffs
|
There was a problem hiding this comment.
As discussed in slack, let's follow up this PR with an investigation into making it go faster (to match the speeds at which Circleci ran the same jobs).
But in case it takes a while to do that work: can you add a new GitHub Issue and a comment in this file linking to the issue, explaining that we should look into making it go faster?
I just don't want people copying this work in the (near) future, not noticing the slow down, and suddenly our tests take hours to pass CI. Hopefully a comment in here will help prevent that.
relevant:
There are 2 reasons it's slower than CircleCI:
|
@HowardBraham Do you think the first point is really a reason for the slow down? I do not necessarily think so, since it is using the yarn cache from GitHub, meaning it does not need to redo the full work. The second point about parallelism is true, we do need a fix for that. |
|
Builds ready [d1be009]
Page Load Metrics (177 ± 216 ms)
Bundle size diffs
|
|
@itsyoboieltr In the |
metamaskbot
added
the
release-12.2.0
| name: Run unit tests | ||
|
|
||
| on: | ||
| pull_request: |
There was a problem hiding this comment.
We need to add a trigger for develop and master here as well. These long-running branches will not have PRs associated with them, but it's very important that we know that tests are passing on them.
Description
This PR moves unit tests from Circleci to Github actions. This is needed to pass the Jest export to SonarCloud in order finalize the SonarCloud integration. The reason why we want to use Github action rather than Circleci is because Sonarcloud integration happens in a Github action and we cannot pass data (i.e. the artifact) from Circleci to Github action.
Related issues
Fixes: https://github.com/MetaMask/MetaMask-planning/issues/2449
Manual testing steps
Screenshots/Recordings
Not applicable
Pre-merge author checklist
Pre-merge reviewer checklist