Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(faucet): hide login flow for mobile devices #1756

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

fix(faucet): hide login flow for mobile devices #1756

wants to merge 4 commits into from

Conversation

TrofimovAnton85
Copy link
Contributor

@TrofimovAnton85 TrofimovAnton85 commented Nov 29, 2024 •
edited
Loading

Description

  • hidden login flow for mobile devices and added the corresponding message

Test

  • on the desktop, go to the /developer-tools/faucet/ and check the login button is available in the navigation bar and on the page
  • check this page on a mobile device (or emulation mode in the web inspector - in this case, reload the page) and check that the button is hidden and there is a message

Screenshot 2024-11-29 at 15 19 22

Screenshot 2024-11-29 at 15 17 38

@TrofimovAnton85 TrofimovAnton85 self-assigned this Nov 29, 2024
@TrofimovAnton85 TrofimovAnton85 requested a review from a team as a code owner November 29, 2024 14:33
@vercel Vercel
Copy link

vercel bot commented Nov 29, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
metamask-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 3, 2024 9:47am

AndyMBridges
AndyMBridges requested changes Nov 29, 2024
View reviewed changes
Copy link
Contributor

@AndyMBridges AndyMBridges left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @TrofimovAnton85 - Instead of importing react-device-detect, can we use any of our existing logic?

@TrofimovAnton85
Copy link
Contributor Author

Hey @TrofimovAnton85 - Instead of importing react-device-detect, can we use any of our existing logic?

Hey! Thanks!
Fixed & committed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndyMBridges AndyMBridges Awaiting requested review from AndyMBridges

Requested changes must be addressed to merge this pull request.

Assignees

@TrofimovAnton85 TrofimovAnton85

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TrofimovAnton85 @AndyMBridges