Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow modifying display type of persistent-others #1223

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

fcjr
Copy link

@fcjr fcjr commented Dec 15, 2024

The persistent dock options can be configured to look like folders, change sorting, and view orientation.

This PR allows you to set these values by passing an optional custom type:

system.defaults.dock.persistent-others = [
    "~/Documents"
    "~/Downloads/file.txt"
    {
      path = "~/Appications";
      displayas = "folder";
      showas = "fan";
      arrangement = "date-modified";
    }
  ];

Copy link
Contributor

@bew bew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello o/
Could we have textual enums for the various values for the arrangement, showas, displayas ?
Or at the very least list the possible values and what they mean 🤔
Could you also explain how showas & displayas are different?

@fcjr
Copy link
Author

fcjr commented Dec 15, 2024

Could we have textual enums for the various values for the arrangement, showas, displayas ? Or at the very least list the possible values and what they mean 🤔 Could you also explain how showas & displayas are different?

Sure, updated w/ slightly better comments and enums

@fcjr fcjr force-pushed the dock branch 2 times, most recently from 8dcd81b to 40d630c Compare December 15, 2024 20:44
@fcjr
Copy link
Author

fcjr commented Dec 16, 2024

New to nix so not too sure how to fix the tests just yet, but continuing to poke around. If anyone has any suggestions lmk :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants