Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for controlling the behaviour of document-proxy icons #1175

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

romen
Copy link

@romen romen commented Nov 16, 2024

Specifically this adds options for:

  • system.defaults.universalaccess.showWindowTitlebarIcons
  • system.defaults.NSGlobalDomain.NSToolbarTitleViewRolloverDelay

See https://macos-defaults.com/finder/nstoolbartitleviewrolloverdelay.html#toolbar-title-rollover-delay

Note: actually I had to disable system.defaults.universalaccess.showWindowTitlebarIcons as I couldn't get it to work.

I am pretty new to nix-darwin, and I can use guidance about this PR!

Specifically this adds options for:

- system.defaults.universalaccess.showWindowTitlebarIcons
- system.defaults.NSGlobalDomain.NSToolbarTitleViewRolloverDelay

See https://macos-defaults.com/finder/nstoolbartitleviewrolloverdelay.html#toolbar-title-rollover-delay
@romen
Copy link
Author

romen commented Nov 16, 2024

Also, probably I should add tests, but I am not sure how to do it testing locally before pushing to a PR

@romen romen marked this pull request as draft November 16, 2024 15:27
@romen
Copy link
Author

romen commented Nov 16, 2024

Ok, the error I was seeing was solved by #1049 (comment)

@romen romen marked this pull request as ready for review November 18, 2024 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant