release(esbuild): 🏹 Release [email protected]

LinbuduLab · Mar 26, 2023 · e5a8479 · e5a8479
1 parent 72fc47c
commit e5a8479
Show file tree

Hide file tree

Showing 7 changed files with 34 additions and 10 deletions.
diff --git a/packages/esbuild-plugin-copy/.gitignore b/packages/esbuild-plugin-copy/.gitignore
@@ -0,0 +1 @@
+issues
diff --git a/packages/esbuild-plugin-copy/.npmignore b/packages/esbuild-plugin-copy/.npmignore
@@ -1,2 +1,3 @@
 src
-tests
+tests
+issues
diff --git a/packages/esbuild-plugin-copy/CHANGELOG.md b/packages/esbuild-plugin-copy/CHANGELOG.md
@@ -1,8 +1,12 @@
 # CHANGELOG
 
+## Release 2.1.1
+
+- BugFix: When copy with `file-to-file`, and the `to` path contains nested unexist path, the plugin will throw error as it doesnot create the nested path by `fs.ensureDirSync`.
+
 ## Release 2.1.0
 
-- Feature: `Watc hMode` support for plugin-level and asset pair level.
+- Feature: `Watch Mode` support for plugin-level and asset pair level.
 
 ## Released 2.0.1
 

diff --git a/packages/esbuild-plugin-copy/package.json b/packages/esbuild-plugin-copy/package.json
@@ -1,6 +1,6 @@
 {
   "name": "esbuild-plugin-copy",
-  "version": "2.1.0",
+  "version": "2.1.1",
   "description": "ESBuild plugin for assets copy.",
   "keywords": [
     "esbuild",

diff --git a/packages/esbuild-plugin-copy/src/lib/esbuild-plugin-copy.ts b/packages/esbuild-plugin-copy/src/lib/esbuild-plugin-copy.ts
@@ -104,7 +104,7 @@ export const copy = (options: Partial<Options> = {}): Plugin => {
 
         if (!build.initialOptions.watch) {
           verboseLog(
-            `Watching mode diabled. You need to enable ${chalk.white(
+            `Watching mode disabled. You need to enable ${chalk.white(
               'build.watch'
             )} option for watch mode to work.`,
             verbose

diff --git a/packages/esbuild-plugin-copy/src/lib/handler.ts b/packages/esbuild-plugin-copy/src/lib/handler.ts
@@ -57,7 +57,8 @@ export function copyOperationHandler(
     const isToPathDir = path.extname(baseToPath) === '';
 
     const composedDistDirPath = isToPathDir
-      ? path.resolve(
+      ? // /RESOLVE_FROM_DIR/SPECIFIED_TO_DIR/LEFT_FILE_STRUCTURE
+        path.resolve(
           // base resolve destination dir
           outDirResolveFrom,
           // configures destination dir
@@ -72,11 +73,7 @@ export function copyOperationHandler(
           baseToPath
         );
 
-    dryRun
-      ? void 0
-      : isToPathDir
-      ? fs.ensureDirSync(path.dirname(composedDistDirPath))
-      : void 0;
+    dryRun ? void 0 : fs.ensureDirSync(path.dirname(composedDistDirPath));
 
     dryRun ? void 0 : fs.copyFileSync(sourcePath, composedDistDirPath);
 

diff --git a/packages/esbuild-plugin-copy/tests/plugin.spec.ts b/packages/esbuild-plugin-copy/tests/plugin.spec.ts
@@ -372,6 +372,27 @@ describe('CopyPlugin:Core', async () => {
 
     expect(d1).toEqual(['hello.txt', 'index.js']);
   });
+  it.only('should copy from file to file with nested dest dir', async () => {
+    const outDir = tmp.dirSync().name;
+
+    await builder(
+      outDir,
+      { outdir: outDir },
+      {
+        assets: {
+          from: path.resolve(__dirname, './fixtures/assets/note.txt'),
+          to: './unexist/nest/dir/hello.txt',
+        },
+        resolveFrom: 'out',
+        verbose: false,
+        dryRun: false,
+      }
+    );
+
+    const d1 = fs.readdirSync(path.join(outDir, 'unexist/nest/dir'), {});
+
+    expect(d1).toEqual(['hello.txt']);
+  });
 });
 
 describe('CopyPlugin:Utils', async () => {
-Original file line number
+Diff line change
@@ -1,2 +1,3 @@
     src
-    tests
+    tests
+    issues