LibWebView: Port to Windows #3002
Conversation
There was a problem hiding this comment.
A general comment on your PRs lately: it'd be helpful if the commit message explained why you made the changes you did. Specifically here the removal of the static asserts. If someone in future wonders why they're gone, (presumably they were added for a reason originally,) and the git blame just tells them "Port to Windows", it doesn't explain why Windows doesn't like these, or the trade offs you made, etc.
I've had a skim of a few of your PRs and generally the commits are clear, but the final "LibFoo: Port to Windows" commits tend to have changes that could use more explanation, especially for someone like me who doesn't know about Windows' differences.
|
These static asserts were placed by @ADKaster just to mark places that might need attention when porting to Windows. They don't even compile - not because the assert fails, but because there is no such type IPC::TransportSocket on Windows (IPC::TransportSocketWindows is used instead). They are essentially elaborate FIXMEs. |
|
They are fixmes yes. But they do need attention when Mach IPC is a thing as well, not just windows |
No description provided.