-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LibCrypto: Replace hashes implementation with OpenSSL #2989
Merged
+275
−1,350
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alimpfard
reviewed
Dec 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Assuming everyone's on board with using openssl, this looks very nice.
A couple stylistic/nitpicky things:
alimpfard
approved these changes
Dec 20, 2024
Related issue: #1834 (for linking) |
ADKaster
reviewed
Dec 20, 2024
rmg-x
reviewed
Dec 20, 2024
Add OpenSSL with vcpkg and link with LibCrypto using CMake. Also added a placeholder GN setup.
This abstract class allows implementing hashes backed by OpenSSL with very few lines of code, see next commit.
This required multiple changes: - Make hashes non-copiable because they contain a heap allocated pointer - Reference classes via `NonnullOwnPtr` only (they are non-copiable) - Drop all existing hashes implementations - Use the `OpenSSLHashFunction` base class to implement the same hashes I was not able to come up with a way to divide this commit into multiple without increasing the amount of changes. Nothing breaks with this commit!
Unrelated CI failure :( |
Let's dew it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to bring OpenSSL into the project as briefly discussed on Discord by replacing all hashes implementation with OpenSSL.
Additional discussion here.
It required multiple changes:
EVP_MD_CTX
manually has been deprecated)NonnullOwnPtr
only (because they are non-copiable)OpenSSLHashFunction
base class to implement the same hashesI was not able to come up with a way to divide this PR into more commits without increasing the amount of changes.
Overall this doesn't break anything and drastically reduces the amout of code. I suspect it also increases performance (that will probably be more obvious with stuff like RSA).