LibWeb: Ignore: “orphaned” ARIA roles, landmark roles which lack required names, role=none for focusable or has-global-ARIA-attribute elements #2972
+578
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sideshowbarker
force-pushed
the
aria_handle_orphaned_roles
branch
from
5b20483 to
6175fe2
Compare
sideshowbarker
changed the title
sideshowbarker
force-pushed
the
aria_handle_orphaned_roles
branch
5 times, most recently
from
2106692 to
2ab1757
Compare
sideshowbarker
changed the title
|
Your pull request has conflicts that need to be resolved before it can be reviewed and merged. Make sure to rebase your branch on top of the latest |
github-actions
bot
added
the
conflicts
This change adds a virtual to_element function to ARIAMixin, and overrides it in DOM::Element so it can then be used back inside ARIAMixin to get an element when needed (for example, when computing a role requires checking the roles of ancestors of an element).
Per https://w3c.github.io/aria/#document-handling_author-errors_roles, determining whether to ignore certain specified landmark roles requires first determining whether the element for which the role is specified has an accessible name. But if we then try to retrieve a role for such elements, we end up calling right back into the accessible-name computation code — which would cause the calls to loop infinitely. So to avoid that — and to have handling for any other future cases the spec may introduce of such recursive calls that will loop indefinitely — this change introduces a parameter that callers can pass to cause role-attribute lookup to be skipped during accessible-name computation.
This change implements the requirements stated in the HTML spec at https://html.spec.whatwg.org/multipage/interaction.html#tabindex-value that UAs must allow HTML elements with non-null tabindex values to be considered as focusable areas.
This change causes explicitly-specified role attributes to be ignored in the case where the specified role is “orphaned” — that is, when its element lacks a required ancestor with an appropriate role.
This change implements the role-checking requirement from the ARIA spec at https://w3c.github.io/aria/#document-handling_author-errors_roles that the"form" and "region" roles are required to have accessible names, and that if they do not have accessible names as required, UAs must treat them as if they’d not be specified at all.
This change causes explicit role=none and role=presentation attribute values to be ignored in cases where the elements for which those values are specified are either focusable, or have global ARIA attributes — per https://w3c.github.io/aria/#conflict_resolution_presentation_none.
sideshowbarker
force-pushed
the
aria_handle_orphaned_roles
branch
from
2ab1757 to
c8f4f7f
Compare
github-actions
bot
removed
the
conflicts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change includes six commits: