LibWeb: Update "create and initialize a document" to currrent spec

[gjf7]

1. Update "create and initialize a document" to currrent spec
2. Add noopener-allow-popups value to OpenerPolicyValue

[AtkinsSJ]

This is failing some tests but it's hard to tell which. Can you rebase on master? #2950 should make the output a bit more readable.

[gjf7]

This is failing some tests but it's hard to tell which. Can you rebase on master? #2950 should make the output a bit more readable.

Hi there, could u approve the ci again? Thanks

[gjf7]

Oh. The return value of scheme() is Optional.

I tried using Optional's value_or() with an empty String as follows:

if (!source_origin.scheme().value_or(String {}).starts_with_bytes("http"sv) || 
    !destination_origin.scheme().value_or(String {}).starts_with_bytes("http"sv)) {
    swap_group = true;
}

However, I'm getting a verification error at runtime:
CopyVERIFICATION FAILED: m_has_value at /Users/haochen/Project/ladybird/AK/Optional.h:317

As I'm new to C++, I'm not sure about the best way to handle this. @AtkinsSJ, could you suggest the proper way to check Optional in this context?

[AtkinsSJ]

I would probably do this:

if (source_origin.scheme.has_value() &&
    (!source_origin.scheme()->starts_with_bytes("http"sv) || !destination_origin.scheme()->starts_with_bytes("http"sv))) {
    // ...
}

[AtkinsSJ]

Oh scratch that, I missed that it's two different variables. 😅
But anyway foo.has_value() && !foo->starts_with_bytes("http"sv) is the check for each one.

[gjf7]

Thanks! I've updated the code. Please let me know if any other changes are needed to merge this PR.