WebContent+LibWeb: Add an option to disable painting viewport scrollbars #2962
+30
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AtkinsSJ
approved these changes
Dec 18, 2024
|
Just for reference, do other browsers take this same route when running WPT? An alternative I could imagine is painting the backing store with a viewport size as big as the document, in which case the scrollbars should disappear as well. |
tcl3
force-pushed
the
webcontent_disable_scrollbar_painting
branch
from
f4e1470 to
0072889
Compare
|
We should also consider disabling these scrollbars during LibWeb tests, it's a frequent pain point in screenshot tests it seems. (Fine to do as a follow-up ofc, since it probably involves rebasing all of those tests) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a
--disable-scrollbar-paintingoption, which stops the scrollbars of viewport paintables from being painted. This option is then used by WebDriver when launching the browser.This gives us 115 additional WPT passes.