Docs: LibWebFromLoadingToPainting.md fix grammar and plural #2957
+2
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SergeCroise
commented
Dec 18, 2024
•
SergeCroise
commented
- a mechanism called formatting contexts
- for all boxes that were ...
trflynn89
reviewed
Dec 18, 2024
| @@ -104,7 +104,7 @@ A number of tree fix-ups are also performed: | |||
| Layout starts at the ICB (initial containing block), which is the layout node that corresponds to the DOM document node. | |||
| CSS says that the ICB should be the size of the viewport, so the very first thing layout does is assign these dimensions. | |||
|
|
|||
| Layout works through a mechanism call formatting contexts. CSS defines a number of different formatting contexts: | |||
| Layout works through a mechanism that calls formatting contexts. CSS defines a number of different formatting contexts: | |||
There was a problem hiding this comment.
I think "called" is what was meant here.
SergeCroise
commented
Dec 19, 2024
|
Hello @trflynn89 , |
|
The second commit fixes something that was incorrect in the first one, so they should probably be squashed into a single commit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.