LibWeb: Avoid re-encoding response headers #2890
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
F3n67u
force-pushed
the
response-header-latin1
branch
3 times, most recently
from
8e6b30a to
002ab62
Compare
|
I believe this also fixes the main issue that prevented me from putting a |
F3n67u
force-pushed
the
response-header-latin1
branch
from
002ab62 to
5664768
Compare
isomorphic encoding a value that has already been encoded will result in garbage data. `response_headers` is already encoded in ISO-8859-1/latin1, we cannot use `from_string_pair`, as it triggers ISO-8859-1/latin1 encoding. Follow-up of LadybirdBrowser#1893
F3n67u
force-pushed
the
response-header-latin1
branch
from
5664768 to
e5a1a0b
Compare
I uncomment |
|
i assume that should fix opening of the cnn.com. It currently fails due to wrongly encoded cookie header |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
isomorphic encoding a value that has already been encoded will result in garbage data.
response_headersis already encoded in ISO-8859-1, we cannot usefrom_string_pair, as it callsisomorphic_decode.Follow-up of #1893