LibWeb: Ensure Headers API can handle non-ascii characters #2814
+188
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
F3n67u
changed the title
F3n67u
force-pushed
the
fetch-headers-get-nonascii
branch
from
7988bea to
3ec3685
Compare
F3n67u
changed the title
F3n67u
force-pushed
the
fetch-headers-get-nonascii
branch
from
3ec3685 to
ad397ab
Compare
F3n67u
changed the title
F3n67u
force-pushed
the
fetch-headers-get-nonascii
branch
4 times, most recently
from
0b18dd5 to
ddd04de
Compare
F3n67u
changed the title
F3n67u
force-pushed
the
fetch-headers-get-nonascii
branch
2 times, most recently
from
1bb9e88 to
dc24a87
Compare
|
This fixes crash in WPT: https://wpt.fyi/results/fetch/api/headers/headers-normalize.any.html |
This patch ensure Headers object's associated header list is ISO-8859-1 encoded when set using `Infra::isomorphic_encode`, and correctly decoded using `Infra::isomorphic_decode`. Follow-up of LadybirdBrowser#1893
F3n67u
force-pushed
the
fetch-headers-get-nonascii
branch
from
dc24a87 to
45a3b61
Compare
Imported, Thank you! |
Gingeh
approved these changes
Dec 11, 2024
ADKaster
approved these changes
Dec 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure the Headers object's associated header list is ISO-8859-1 encoded
when set using
Infra::isomorphic_encodeand correctly decoded usingInfra::isomorphic_decode.Follow-up of #1893