LibWeb: Use GlyphRun fonts, not the first available font, for more things #2796
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partly addresses #2787.
I found a few places where we're calling
first_available_font()
for things where we actually want to know the exact font used by these particular code-points. And, I've fixed some. Specifically, selection rectangles and text-editing cursor positions.Before
Screencast_20241205_200256.webm
After
Screencast_20241205_200448.webm
Source
It is absolutely not perfect still. A couple of issues:
The remaining spots we don't handle, which I've FIXME'd:
(There are also several places where using the first available font is appropriate as far as I can tell, so I've left those.)
We might have other places we do the wrong thing like this, but I'm sure we'll notice those eventually.