[pull] master from aws:master #108
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pull[bot]](https://avatars.githubusercontent.com/in/12910?s=60&v=4){kind=small}
* fix: s3 200 errors handling - This change includes the following: -- Refactor the s3 200 response error handling logic so it can be opened for all s3 operations. -- Migrate some S3 parsers to a result mutator implementation so the code can be a bit cleaner. * fix: remove get-object from 200 retries test GetObject operation has a streaming member which will be ignored and hence not treated as a 200 s3 error. * fix: evaluate streaming for s3 200 error Make sure that operations where any of its member has an eventstream or streaming trait are ignored. * chore: address PR feedback - Split statements into multiple lines to improve readability. - Make pattern variable for finding the Error element name to be static. - Add a test in the GetBucketLocationResultMutatorTest to make sure the mutator just applies to GetBucketLocation. - Move some values into static variables in the GetBucketLocationMutator implementation. - Change the visibility of some methods in the ValidateResponseCheckResultMutator from public to private. - Refactor the tests on ValidateResponseCheckResultMutatorTest to make them be executed from the mutator invokation instead of testing those methods independently.
Co-authored-by: Sean O'Brien <[email protected]>
Update changelong for `3.324.6 - 2024-10-18` with a more detailed breaking change message for the Athena service model change.
* enhancement: user agent 2.1 This change provides: - A builder class for appending metrics - Default initialization of a metrics builder within command instantiation - Wraps user agent logic into a single middleware class - Adds middlewares into the different features from where metrics can be gather, to acomplish this purpose. * feat: user agent v2.1 second revision - Move the user agent middleware after the signing step in order to gather signature metrics. - Add request compression metric gathering. - Add specific testing for signatures. - Add specific testing for request compression. - Add specific testing for s3 encryption clients. - Add credentials metric gathering logic. - Add tests for credentials metrics. - Make existent credentials tests to work with the new field `source`. For example, for tests around profile credentials the source property for credentials MUST be `profile`. The default value for this field is `static`. * chore: address PR feedback - Use static mapping instead of multiple if/else-ifs. - Remove the endpoint_id metric tracking since it was removed from the spec. - Make method's name to be verb based. - Remove the getMetricsBuilder from the CommandInterface. * chore: add credentials->source tests - Add tests cases to cover credentials sets the correct source when resolved. - Fix the sso, sso_legacy, and process metrics. They should be all a profile based metric. * chore: add missing blank lines
This change provides: - A builder class for appending metrics - Default initialization of a metrics builder within command instantiation - Wraps user agent logic into a single middleware class - Adds middlewares into the different features from where metrics can be gather, to acomplish this purpose. - Move the user agent middleware after the signing step in order to gather signature metrics. - Add request compression metric gathering. - Add specific testing for signatures. - Add specific testing for request compression. - Add specific testing for s3 encryption clients. - Add credentials metric gathering logic. - Add tests for credentials metrics. - Make existent credentials tests to work with the new field `source`. For example, for tests around profile credentials the source property for credentials MUST be `profile`. The default value for this field is `static`. - Use static mapping instead of multiple if/else-ifs. - Remove the endpoint_id metric tracking since it was removed from the spec. - Make method's name to be verb based. - Remove the getMetricsBuilder from the CommandInterface. - Add tests cases to cover credentials sets the correct source when resolved. - Fix the sso, sso_legacy, and process metrics. They should be all a profile based metric.
Add changelogs for user agent 2.1 implementation.
* fix: add endpoint override flag This change is needed because the parameter `endpoint` will always be populated even if a value was not provided at client construction, and therefore we can not relay on it to determine its source. * chore: fix endpoint override test
Basically, some e2e tests do not use the latest SDK version and therefore latest changes in the endpoint rule set file are not present there, which makes some of tests depending on those latest changes to fail. In this specific case it failed when checking if an account id was resolved or not in dynamodb, because the endpoint ruleset file did not contain the AccountId parameter. For fixing this I use a custom endpoint provider where the ruleset file contains the needed parameter and rule.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )