Change return type of named swizzles #672
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is change 5 of 9 that fix problems with the specification of the
`vec` class. An implementation that follows the existing specification
would not accept common code patterns and would not pass the CTS. None
of the existing implementations actually follow the existing
specification.
This change aligns the return type of the 1-element "named" swizzles to
the behavior of the existing implementations (and the CTS). This
changes the specified behavior of code like this:
```
vec<uint8_t, 4> v4{255};
auto v = v4.x(); // Returns reference to "uint8_t" not 1-element swizzle
int i = v4.x() + 1; // Result is 256 not 0
```
These changes correspond to slides 19 - 22 of the presentation that was
discussed in the WG meetings.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is change 5 of 9 that fix problems with the specification of the
vecclass. An implementation that follows the existing specification would not accept common code patterns and would not pass the CTS. None of the existing implementations actually follow the existing specification.This change aligns the return type of the 1-element "named" swizzles to the behavior of the existing implementations (and the CTS). This changes the specified behavior of code like this:
These changes correspond to slides 19 - 22 of the presentation that was discussed in the WG meetings.