Fix 1-element "vec" ambiguities #670
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is change 3 of 9 that fix problems with the specification of the `vec` class. An implementation that follows the existing specification would not accept common code patterns and would not pass the CTS. None of the existing implementations actually follow the existing specification. This change fixes an ambiguity that occurs for all of the binary operators when one of the operands is a 1-element `vec` and the other operand is a scalar that is not `DataT` but is convertible to `DataT`. For example: ``` sycl::vec<float, 1> v; v + 2; ``` Prior to this change, this would result in an ambiguity error from the compiler between: * Convert 2 -> `float`, call `operator+(const vec&, const DataT&)` * Convert `vec<float, 1>` -> `float`, call `operator+(float, int)` After this change, the code snippet above compiles without error, calling `operator+(const vec&, const int&)` that is instantiated from a template. These changes correspond to slides 10 - 13 of the presentation that was discussed in the WG meetings.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is change 3 of 9 that fix problems with the specification of the
vecclass. An implementation that follows the existing specification would not accept common code patterns and would not pass the CTS. None of the existing implementations actually follow the existing specification.This change fixes an ambiguity that occurs for all of the binary operators when one of the operands is a 1-element
vecand the other operand is a scalar that is notDataTbut is convertible toDataT. For example:Prior to this change, this would result in an ambiguity error from the compiler between:
float, calloperator+(const vec&, const DataT&)vec<float, 1>->float, calloperator+(float, int)After this change, the code snippet above compiles without error, calling
operator+(const vec&, const int&)that is instantiated from a template.These changes correspond to slides 10 - 13 of the presentation that was discussed in the WG meetings.