Fix definition of RET for vec operators #666
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes what I assume was just a typo. The `vec` comparison and logical operators all return a result type whose vector element is `RET`. Most of the operators say that `RET` is `int64_t` when the input operands are 64-bit. However, three of the operators defined `RET` to be `uint64_t` in this case. The `uint64_t` type is an outlier because `RET` is always signed for the other cases. I can think of no reason why these three operators should be different from the others. DPC++ already implements these operators to return a vector of `int64_t`, consistent with this fix.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes what I assume was just a typo. The
veccomparison and logical operators all return a result type whose vector element isRET. Most of the operators say thatRETisint64_twhen the input operands are 64-bit. However, three of the operators definedRETto beuint64_tin this case.The
uint64_ttype is an outlier becauseRETis always signed for the other cases. I can think of no reason why these three operators should be different from the others.DPC++ already implements these operators to return a vector of
int64_t, consistent with this fix.