Add sycl_khr_addrspace_cast extension #650
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This extension splits sycl::address_space_cast into two functions: - khr::static_addrspace_cast, which casts with no run-time checks. - khr::dynamic_addrspace_cast, which casts with run-time checks.
Providing static_addrspace_cast and dynamic_addrspace_cast via two separate extensions gives implementations the flexibility to support one but not the other.
|
As proposed in last week's WG meeting, I've split this into two extensions: 760627f |
keryell
reviewed
Nov 14, 2024
Co-authored-by: Ronan Keryell <[email protected]>
gmlueck
reviewed
Nov 14, 2024
gmlueck
approved these changes
Nov 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This extension splits
sycl::address_space_castinto two functions:khr::static_addrspace_cast, which casts with no run-time checks.khr::dynamic_addrspace_cast, which casts with run-time checks.