Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lsp: Make vim support more explicit, add code completions #5917

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

V-FEXrt
Copy link

@V-FEXrt V-FEXrt commented Dec 12, 2024

  • Adds explicit instructions on how to build/install the LSP as a standalone binary
  • Adds explicit instructions on how to install/configure the LSP and syntax file in neovim
  • Adds support for code completion such that typing % will prompt all PIdents in the current file and typing any other alphanumeric will prompt all opcodes filtered by a fuzzy match
  • Updates the hover (and code completion) doc text for an opcode to have more information (ex: opcode class & opcode operands)

Things that should probably be improved

  • Instructions for building/installing on neovim are linux specific right now
  • Code completion will suggest opcodes in places that don't make sense like the operands

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@V-FEXrt
Copy link
Author

V-FEXrt commented Dec 12, 2024

utils/vscode/src/schema/schema.go and utils/vscode/spirv.json being generated and checked it makes this PR look way larger than it actually is. Might not be a bad idea to git ignore those files at some point. I can also just revert them to their last state if that is preferred

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants