Fix errors in test_vulkan
#2183
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add `CL_INVALID_SEMAPHORE_KHR` to the error string helper function. Signed-off-by: Ahmed Hesham <[email protected]>
Calling `clEnqueue{Wait,Signal}SemaphoresKHR` with an invalid
semaphore should return `CL_INVALID_SEMAPHORE_KHR` and not
`CL_INVALID_VALUE`.
Signed-off-by: Ahmed Hesham <[email protected]>
Check that the device supports the `VK_KHR_EXTERNAL_MEMORY_CAPABILITIES` extension before adding an entry for `VULKAN_EXTERNAL_MEMORY_HANDLE_TYPE_OPAQUE_FD` to the list of supported Vulkan external memory handle types. Signed-off-by: Ahmed Hesham <[email protected]>
If the device does not support the required extension, skip the test, instead of throwing an exception and failing. Signed-off-by: Ahmed Hesham <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes three problems in
test_vulkan:clEnqueue{Wait,Signal}SemaphoresKHRwith an invalid semaphore should returnCL_INVALID_SEMAPHORE_KHRand notCL_INVALID_VALUE.When populating the list of supported external memory handle types for Vulkan, the types are unconditionally added to the list, without checking if the device supports it or not, this fix is namely for
VULKAN_EXTERNAL_MEMORY_HANDLE_TYPE_OPAQUE_FD.If a device does not support an optional extension (that is required for a test), the test should skip, not throw an exception and fail. A test failure should be reserved for the cases where a device claims support for an extension but then fails to execute the test correctly.