add a unified SVM consistency check test #2174
Conversation
|
Hmm, the CI build checks are going to fail unless we update the scripts to pull the headers from KhronosGroup/OpenCL-Headers#269. |
|
I've updated the test as we discussed. I also pulled in the CI changes so the unified SVM headers are used, and now the automated builds are working again. |
|
|
||
| REGISTER_TEST(unified_svm_consistency) | ||
| { | ||
| if (!is_extension_available(deviceID, "cl_khr_unified_svm")) |
There was a problem hiding this comment.
I've not been following the unified svm test plan closely, but is the idea that the extension tests will live in test_conformance/SVM rather than test_conformance/extensions/cl_khr_unified_svm?
There was a problem hiding this comment.
Good question. I don't think we've discussed this. I'll create a new test executable if that's what the group prefers, but I think we've generally tried to minimize test executables, so I'm inclined to put the unified SVM tests here unless we have a good reason to do otherwise.
Adds a unified SVM consistency check test, as per the description in #2150.
Note that the target branch for this PR is the cl_khr_unified_svm branch, not the main branch.