update and modernize the platform extensions test #2172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'll keep this as a draft until the spec issue is resolved. |
ahesham-arm
reviewed
Dec 10, 2024
ahesham-arm
reviewed
Dec 10, 2024
Platform extensions may be supported by the platform only, without being supported by devices in the platform.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the platform extensions test to behave the way I expect it should behave. See discussion: KhronosGroup/OpenCL-Docs#1287
CL_PLATFORM_EXTENSIONSthen it should also be reported inCL_DEVICE_EXTENSIONS.CL_DEVICE_EXTENSIONSfor all devices then it should also be reported inCL_PLATFORM_EXTENSIONS.The first commit simply fixes the formatting in this file and can be ignored for easier review.