Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow keyboard navigation of images #1990

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Allow keyboard navigation of images #1990

wants to merge 6 commits into from

Conversation

SonicScrewdriver
Copy link
Contributor

@SonicScrewdriver SonicScrewdriver commented Dec 12, 2024

Summary:

This PR allows the keyboard navigation of our images so that users can easily interact with the zoom functionality. I have also added the spacebar and enter keys as optional methods for closing the image, just to help avoid any confusion for our users.

Issue: LEMS-2697

Test plan:

  • manual testing
  • a new test that I should add tomorrow morning.

@SonicScrewdriver SonicScrewdriver self-assigned this Dec 12, 2024
Copy link
Contributor

github-actions bot commented Dec 12, 2024

npm Snapshot: Published

Good news!! We've packaged up the latest commit from this PR (4ecee88) and published it to npm. You
can install it using the tag PR1990.

Example:

yarn add @khanacademy/perseus@PR1990

If you are working in Khan Academy's webapp, you can run:

./dev/tools/bump_perseus_version.sh -t PR1990

Copy link
Contributor

github-actions bot commented Dec 12, 2024

Size Change: +48 B (0%)

Total Size: 1.27 MB

Filename Size Change
packages/perseus/dist/es/index.js 415 kB +48 B (+0.01%)
ℹ️ View Unchanged
Filename Size
packages/kas/dist/es/index.js 39 kB
packages/keypad-context/dist/es/index.js 760 B
packages/kmath/dist/es/index.js 4.27 kB
packages/math-input/dist/es/index.js 77.9 kB
packages/math-input/dist/es/strings.js 1.79 kB
packages/perseus-core/dist/es/index.js 1.48 kB
packages/perseus-editor/dist/es/index.js 688 kB
packages/perseus-linter/dist/es/index.js 22.2 kB
packages/perseus/dist/es/strings.js 3.7 kB
packages/pure-markdown/dist/es/index.js 3.66 kB
packages/simple-markdown/dist/es/index.js 12.5 kB

compressed-size-action

Copy link
Contributor

@mark-fitzgerald mark-fitzgerald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified functionality in Storybook (with zoomed image).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants