-
Notifications
You must be signed in to change notification settings - Fork 350
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow keyboard navigation of images #1990
base: main
Are you sure you want to change the base?
Conversation
npm Snapshot: PublishedGood news!! We've packaged up the latest commit from this PR (4ecee88) and published it to npm. You Example: yarn add @khanacademy/perseus@PR1990 If you are working in Khan Academy's webapp, you can run: ./dev/tools/bump_perseus_version.sh -t PR1990 |
Size Change: +48 B (0%) Total Size: 1.27 MB
ℹ️ View Unchanged
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Verified functionality in Storybook (with zoomed image).
20b2272
to
346e7ed
Compare
Summary:
This PR allows the keyboard navigation of our images so that users can easily interact with the zoom functionality. I have also added the spacebar and enter keys as optional methods for closing the image, just to help avoid any confusion for our users.
Issue: LEMS-2697
Test plan: