-
Notifications
You must be signed in to change notification settings - Fork 350
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IframeContentRenderer: formalize iframe communication #1565
base: feature/editor-preview-cleanup
Are you sure you want to change the base?
IframeContentRenderer: formalize iframe communication #1565
Conversation
GeraldRequired Reviewers
Don't want to be involved in this pull request? Comment |
b155429
to
9e61e0f
Compare
Size Change: +977 B (+0.11%) Total Size: 860 kB
ℹ️ View Unchanged
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## feature/editor-preview-cleanup #1565 +/- ##
==================================================================
+ Coverage 70.31% 71.27% +0.95%
==================================================================
Files 521 525 +4
Lines 107245 107437 +192
Branches 7799 11062 +3263
==================================================================
+ Hits 75408 76571 +1163
+ Misses 31652 30866 -786
+ Partials 185 0 -185
... and 140 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
npm Snapshot: PublishedGood news!! We've packaged up the latest commit from this PR (12ecccd) and published it to npm. You Example: yarn add @khanacademy/perseus@PR1565 If you are working in Khan Academy's webapp, you can run: ./dev/tools/bump_perseus_version.sh -t PR1565 |
3d6f3ad
to
25fedd1
Compare
8e065e6
to
3121602
Compare
datasetKey="mobile" | ||
datasetValue={isMobile} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We only ever passed "mobile" here, so I've encoded that as a single prop instead of this generic key/value pair. This will make it easier to understand on the consuming side also (webapp).
a0a975f
to
3a0a245
Compare
b4b9430
to
16550a5
Compare
…o formalize iframe communication
…atasetKey/datasetValue props
3a0a245
to
12ecccd
Compare
Summary:
This PR introduces a formal messaging system with Typescript types to define each message passing between the editor and iframe preview page. This enables us to more easily see how the communication flows and ensures we know what data is expected on both ends.
Issue: LEMS-1809
Test plan:
yarn tsc
yarn test