Move websocket headers to opt function 'WithWebsocketHeaders'

[HaraldNordgren]

Follow-up up on the discussion in #360 (review).

Move websocket headers to and opt function 'WithWebsocketHeaders'.

I have:

• Written a clear PR title and description (above)
• Signed the Khan Academy CLA
• Added tests covering my changes, if applicable
• Included a link to the issue fixed, if applicable
• Included documentation, for new features
• Added an entry to the changelog

[HaraldNordgren]

@benjaminjkraft Here is a follow-up PR regarding our discussion here: #360 (review)

This is without tests now, which is not great.

I'm struggling to find an easy way to test this. Normally I would set up a middleware and set the authentication ctx key for the header. But it seems that the httptest server does not have middleware support out-of-the-box. Maybe I'm wrong?

Could be wise to hold off merging this until tests have been added 🤗

[benjaminjkraft]

Thanks!

I think you should be able to do middleware? gqlgenServer is just an http.Handler, so if you have a middleware that's func(http.Handler) http.Handler you can just do NewServer(middleware(gqlgenServer)).

[HaraldNordgren]

@benjaminjkraft Thanks! Tests added now!

[benjaminjkraft]

Excellent, thanks!