Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve HTTP error text #364

Merged
merged 1 commit into from
Dec 1, 2024
Merged

Improve HTTP error text #364

merged 1 commit into from
Dec 1, 2024

Conversation

benjaminjkraft
Copy link
Collaborator

Thanks to Craig for the suggestion! Since people may have, before #363, been parsing the text, I mentioned it as a breaking change, although I imagine most people are parsing just the code, not the text.

I have:

  • Written a clear PR title and description (above)
  • Signed the Khan Academy CLA
  • Added tests covering my changes, if applicable
  • Included a link to the issue fixed, if applicable
  • Included documentation, for new features
  • Added an entry to the changelog

@benjaminjkraft
Improve HTTP error text
3c2f9e4 
Thanks to Craig for the suggestion! Since people may have, before #363,
been parsing the text, I mentioned it as a breaking change, although I
imagine most people are parsing just the code.
csilvers
csilvers approved these changes Nov 30, 2024
View reviewed changes
Copy link
Member

@csilvers csilvers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@benjaminjkraft benjaminjkraft merged commit 5913cd6 into main Dec 1, 2024
8 checks passed
@benjaminjkraft benjaminjkraft deleted the benkraft.http-error-2 branch December 1, 2024 01:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@csilvers csilvers csilvers approved these changes

@dnerdy dnerdy Awaiting requested review from dnerdy dnerdy is a code owner

@StevenACoffman StevenACoffman Awaiting requested review from StevenACoffman StevenACoffman is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@benjaminjkraft @csilvers