Update Go (and golangci-lint, and gqlgen) versions, and test codegen #362
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Originally my goal here was to add a check that generated code is up to date. (In #360 I was reminded that we have that for first-party code, but not gqlgen.) Then I figured I'd update the Go version to support 1.23, which required updating gqlgen and golangci-lint, both of which now have minimum Go versions of 1.22. So now that's ours too. Those are the only upstream supported versions anyway, so hopefully people are updated. I suspect the CI version-setting stuff can get simplified a bit with all the Go toolchain version stuff, but for now I didn't bother.
benjaminjkraft
requested review from
csilvers,
dnerdy and
StevenACoffman
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Originally my goal here was to add a check that generated code is up to date. (In #360 I was reminded that we have that for first-party code, but not gqlgen.)
Then I figured I'd update the Go version to support 1.23, which required updating gqlgen and golangci-lint, both of which now have minimum Go versions of 1.22. So now that's ours too. Those are the only upstream supported versions anyway, so hopefully people are updated.
I suspect the CI version-setting stuff can get simplified a bit with all the Go toolchain version stuff, but for now I didn't bother.
I have: