Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Show clear filter menu if emptyModes filter fns is selected #914

Merged
merged 4 commits into from
Jan 5, 2024

Conversation

alexzrp
Copy link
Contributor

@alexzrp alexzrp commented Jan 4, 2024

If a filter fns empty or notEmpty is used, the option clear filter in menu dont need show. The bug founded if select empty, because filter value is a space char

If a filter fns empty or notEmpty is used, the option clear filter in menu dont need show.
The bug founded if select empty, because filter value is a space char
Copy link

vercel bot commented Jan 4, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
material-react-table ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 5, 2024 5:46am
material-react-table-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 5, 2024 5:46am

@alexzrp alexzrp changed the title Hide clear filter menu Fixed Show clear filter menu if emptyModes filter fns is selected Jan 4, 2024
@KevinVandy
Copy link
Owner

fixing the menu item instead of removing it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants