-
-
Notifications
You must be signed in to change notification settings - Fork 460
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: creating row with external button #903
Feat: creating row with external button #903
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@dangkhoa99 I think my changes to this PR make more sense. Take a look |
@KevinVandy In my case, when enableRowAction = false, I want when creatingDisplayMode="row" the save or cancel button does not show the action column and the buttons are shown on the table header. |
The problem is that onCreatingRowCancel is not a required option, so we cannot rely on it for conditional rendering |
You can just use columnVisibility state to completely hide the actions column if needed |
I set enableRowAction = false in useMaterialReactTable but this column still show when i setCreatingRow(true) |
I want to implement both editingMode and creatingMode = 'row' similar to MUI as referenced link below: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hide row save button unless onCreatingRowSave
has been defined
Hello @KevinVandy,
According to your code, when using
creatingDisplayMode = 'row'
, it will automatically createsave
andcancel
buttons in theaction
column.But in my case, I want to use
save
,cancel
buttons in the table header to be able to controlcreatingRow
. Can you review and merge the code?Example: