close #KLI-165 Webアプリによる走行ログ可視化 #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YKhm20020
requested changes
Sep 6, 2024
src/csv_to_json.py
Outdated
| """CSVファイルをJSONファイルに変換するクラス.""" | ||
|
|
||
| def __init__(self, csv_file_path: str) -> None: | ||
| """コンストラクタ.""" |
There was a problem hiding this comment.
Suggested change
| """コンストラクタ.""" | |
| """コンストラクタ.""" | |
| Args: | |
| csv_file_path (str): CSVファイルのパス | |
| """ |
こんな感じで、他の箇所も含めて、docstringに Args などを追記してください。
src/csv_to_json.py
Outdated
| self._write_json(data) | ||
|
|
||
| def _read_csv(self) -> List[dict]: | ||
| """CSVファイルを読み込み、辞書のリストを返す.""" |
There was a problem hiding this comment.
ここも引数はないけど返り値について、Return: という形で、返り値についての型と説明を明記してください。
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
チェックリスト
変更点
添付資料