Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New package: PartitionedMPSs v0.5.3 #120538

Merged

Conversation

JuliaRegistrator
Copy link
Contributor

UUID: 17ce1de9-5131-45e3-8a48-9723b6e2dc23
Repo: https://github.com/tensor4all/PartitionedMPSs.jl.git
Tree: d90689fd1ce7f31f3bf7a45f48679965e93aff45

Registrator tree SHA: 17aec322677d9b81cdd6b9b9236b09a3f1374c6a
Copy link
Contributor

github-actions bot commented Dec 2, 2024

Hello, I am an automated registration bot. I help manage the registration process by checking your registration against a set of AutoMerge guidelines. If all these guidelines are met, this pull request will be merged automatically, completing your registration. It is strongly recommended to follow the guidelines, since otherwise the pull request needs to be manually reviewed and merged by a human.

1. New package registration

Please make sure that you have read the package naming guidelines.

2. AutoMerge Guidelines are all met! ✅

Your new package registration met all of the guidelines for auto-merging and is scheduled to be merged when the mandatory waiting period (3 days) has elapsed.

3. To pause or stop registration

If you want to prevent this pull request from being auto-merged, simply leave a comment. If you want to post a comment without blocking auto-merging, you must include the text [noblock] in your comment.

Tip: You can edit blocking comments to add [noblock] in order to unblock auto-merging.

@goerz
Copy link
Member

goerz commented Dec 2, 2024

[noblock] I think it might be okay (aka preferable) to write out the acronym, as PartitionedMatrixProductStates

@shinaoka
Copy link
Contributor

shinaoka commented Dec 2, 2024

[noblock] Thank you for the suggestion. I have updated the readme file.

@goerz
Copy link
Member

goerz commented Dec 2, 2024

[noblock] Oh, the README was fine. I was suggesting renaming the package itself. We generally try to avoid acronyms in package names, so naming the package PartitionedMatrixProductStates would be more in line with the naming guidelines. Of course, it is a bit on the long side, so I'm leaving it up to you.

@shinaoka
Copy link
Contributor

shinaoka commented Dec 2, 2024

[noblock] Oh, I see. The package name may be consistent with related packages such as ITensorMPS.jl.

@goerz
Copy link
Member

goerz commented Dec 2, 2024

[noblock] Alright, fair enough

@JuliaTagBot JuliaTagBot merged commit 55d62c6 into master Dec 5, 2024
15 checks passed
@JuliaTagBot JuliaTagBot deleted the registrator-partitionedmpss-17ce1de9-v0.5.3-a2b129efa8 branch December 5, 2024 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants