Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CompatHelper.yml #6

Merged
merged 3 commits into from
Feb 19, 2024
Merged

Update CompatHelper.yml #6

merged 3 commits into from
Feb 19, 2024

Conversation

devmotion
Copy link
Member

@devmotion devmotion commented Aug 16, 2023

I re-enabled CompatHelper (had missed HTTP 1) but it seems the configuration is outdated and has insufficient permissions. I updated it with the one from the CompatHelper repo.

Run of CompatHelper with the branch of this PR: https://github.com/JuliaHealth/SMARTBackendServices.jl/actions/runs/5880285094/job/15946217884

@devmotion devmotion requested a review from DilumAluthge August 16, 2023 14:44
@devmotion
Copy link
Member Author

Is it clear what causes the test failures? And it seems codecov is not uploaded?

More relevant for this PR: Do you have an idea why the CompatHelper fails on this branch @DilumAluthge? Might regenerating the private keys help?

@DilumAluthge
Copy link
Member

Yeah, let me re-generate the SSH deploy keypair.

@devmotion
Copy link
Member Author

Did you regenerate the keys yet?

@devmotion
Copy link
Member Author

Seems CompatHelper works with the new key! Thank you @DilumAluthge!

@devmotion
Copy link
Member Author

devmotion commented Sep 6, 2023

Copied from Slack:

Coming back to the SMARTBackendServices test failures - I can reproduce them also on the master branch locally. They seem to be caused by the call in

smart_result = backend_services(smart_config)
, or more precisely by the request in
_response = HTTP.request(
"POST",
config.token_endpoint;
headers = Dict("Content-Type" => "application/x-www-form-urlencoded"),
body = URIs.escapeuri(body_params),
)
. Based on the error message in the response I assume the error is returned at https://github.com/smart-on-fhir/smart-launcher-v2/blob/3c79b5032adc576fba2e5d4258d61d4e0f189778/backend/routes/auth/token.ts#L75. Do you have an immediate idea of what could be wrong with our request (or what has changed in smart-launcher) that could explain this error or should I keep digging?

Copy link

codecov bot commented Feb 14, 2024

Welcome to Codecov 🎉

Once merged to your default branch, Codecov will compare your coverage reports and display the results in this comment.

Thanks for integrating Codecov - We've got you covered ☂️

@devmotion devmotion added this pull request to the merge queue Feb 19, 2024
@DilumAluthge
Copy link
Member

You likely want to remove this from the merge queue. Merge queue CI won't run until #11 is merged.

@devmotion devmotion removed this pull request from the merge queue due to a manual request Feb 19, 2024
@devmotion devmotion added this pull request to the merge queue Feb 19, 2024
Merged via the queue into master with commit 053f050 Feb 19, 2024
6 of 7 checks passed
@devmotion devmotion deleted the dw/compathelper branch February 19, 2024 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants