-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Custom values for brain_phantom #484
Open
gsahonero
wants to merge
23
commits into
JuliaHealth:master
Choose a base branch
from
gsahonero:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
23 commits
Select commit
Hold shift + click to select a range
271d98f
Custom values for brain_phantom
gsahonero a67c5bd
Update Phantom.jl
gsahonero afbd05b
Introducing default brain phantom properties
gsahonero 262bf14
Merge branch 'master' of https://github.com/gsahonero/KomaMRI.jl
gsahonero cf83a9e
Details on documentation
gsahonero f858ef1
Updating to remove unnecessary things
gsahonero 0294f4b
Returning phantom to original code
gsahonero 165b793
Resolving problems in brain phantom
gsahonero 91d59f5
Merge branch 'master' of https://github.com/gsahonero/KomaMRI.jl
gsahonero 6b990f4
Merge branch 'JuliaHealth:master' into master
gsahonero 5b6e25d
Avoiding flat arrays.
gsahonero 4020c3d
Merge branch 'JuliaHealth:master' into master
gsahonero 4e4896b
Merge branch 'master' into master
cncastillo 3689518
Update Phantom.jl
gsahonero 9bfe36b
Merge branch 'master' into master
cncastillo 9cc9d29
Update KomaMRIBase/src/datatypes/Phantom.jl
gsahonero 1b9aa93
Update KomaMRIBase/src/datatypes/Phantom.jl
gsahonero bd6b91e
Update KomaMRIBase/src/datatypes/Phantom.jl
gsahonero f55d387
Update KomaMRIBase/src/datatypes/Phantom.jl
gsahonero ecc9bbe
Update KomaMRIBase/src/datatypes/Phantom.jl
gsahonero 1079053
Requested changes
gsahonero b843b60
Removing a println
gsahonero e61cd85
Reducing lines
gsahonero File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you try one last thing?
The sorting and use of
tissue_texts
, does not make a lot of sense. It is better iftissue_labels
is also a dictionary (Dict("CSF" => 23, ...)
), and we index it by thedefault_properties
keys.You should be able to do:
Also, don't forget the spaces between the
*
!