Fix MPSNDArrayDescriptor wrapper

[christiangnrd]

I realized automatically reversing dimensions in the descriptor as part of the low-level wrappers is a terrible idea.

Also a few more improvements

Also using this as an opportunity to test the [skip benchmark] and benchmarking from a fork. Edit: It works

[codecov]

Codecov Report

Attention: Patch coverage is 41.17647% with 10 lines in your changes missing coverage. Please review.

Project coverage is 77.46%. Comparing base (52d7056) to head (8654f9f).
Report is 385 commits behind head on main.

Files with missing lines	Patch %	Lines
lib/mps/ndarray.jl	43.75%	9 Missing ⚠️
lib/mps/MPS.jl	0.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #502      +/-   ##
==========================================
+ Coverage   71.04%   77.46%   +6.42%     
==========================================
  Files          36       57      +21     
  Lines        1143     2742    +1599     
==========================================
+ Hits          812     2124    +1312     
- Misses        331      618     +287     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[christiangnrd]

@maleadt It seems like PR benchmark jobs are not commenting and are being uploaded because

Metal.jl/.github/workflows/Benchmark.yml

Line 45 in 5a8daaa

comment-always: ${{ github.event_name == 'pull_request' }}

and

Metal.jl/.github/workflows/Benchmark.yml

Line 49 in 5a8daaa

auto-push: ${{ github.event_name != 'pull_request' }}

were overlooked when changing pull_request to pull_request_target.

Should I add it to this PR or would it be better for you to commit the fix directly?

[maleadt]

Ah oops. Feel free to commit directly on master, because the modified Benchmark.yml on this PR wouldn't get loaded (at least I think it wouldn't, because of using the pull_request_base instead of pull_request).

We should probably also edit out or revert the upload on the gh-pages branch.

[christiangnrd]

We should probably also edit out or revert the upload on the gh-pages branch.

Done. I assume the benchmark page will update next time a benchmark action runs?

Feel free to commit directly on master

I don't think I have permission to commit directly to main. I tried and got the following error:

remote: error: GH006: Protected branch update failed for refs/heads/main.
remote: 
remote: - Changes must be made through a pull request.
To https://github.com/JuliaGPU/Metal.jl.git
 ! [remote rejected]   main -> main (protected branch hook declined)
error: failed to push some refs to 'https://github.com/JuliaGPU/Metal.jl.git'