Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweak benchmark CI job #501

Merged
merged 10 commits into from
Dec 18, 2024
Merged

Tweak benchmark CI job #501

merged 10 commits into from
Dec 18, 2024

Conversation

maleadt
Copy link
Member

@maleadt maleadt commented Dec 17, 2024

No description provided.

We won't see these changes anyway, running from pull_request_target.
[only benchmarks]
Copy link
Contributor

@christiangnrd christiangnrd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Doesn't work now that we look at the PR base.
But should work already since we ignore skipped builds.

[only benchmarks]
@maleadt
Copy link
Member Author

maleadt commented Dec 18, 2024

The GitHub action doesn't run here since it loads the Benchmark.yml from the merge base, which is a commit with [skip benchmarks] on. So I'm not 100% sure things will work, but we'll have to merge and see.

@maleadt maleadt merged commit ba62282 into main Dec 18, 2024
1 check was pending
@maleadt maleadt deleted the tb/benchmarks branch December 18, 2024 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants