-
-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add the plugin:vitest/recommended in extends array #822
feat: add the plugin:vitest/recommended in extends array #822
Conversation
Codecov Report
@@ Coverage Diff @@
## main #822 +/- ##
==========================================
+ Coverage 91.61% 92.18% +0.56%
==========================================
Files 84 84
Lines 4161 4220 +59
Branches 248 261 +13
==========================================
+ Hits 3812 3890 +78
+ Misses 349 330 -19
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✨ Love it! Very close, just one thought on using a Vitest API instead of a disable comment. Thoughts?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💯 thanks!
🎉 This is included in version v1.29.41 🎉 The release is available on: Cheers! 📦🚀 |
PR Checklist
status: accepting prs
Overview
This PR is responsible for adding the
plugin:vitest/recommended
to the extends array in the.eslintrc.cjs
file.This PR also updates a few of the tests because once the
plugin:vitest/recommended
was added, some of the tests failed the lint checks.For the following files, I replaced the
toEqual
methods with thetoBe
methods per the vitest recommendationsFor the following files, I replaced the
toBe(undefined)
withtoBeUndefined()
per the vitest recommendations