Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: move script/ inclusion to TSConfig #1744

Merged
merged 3 commits into from
Dec 5, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion eslint.config.js
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ export default tseslint.config(
languageOptions: {
parserOptions: {
projectService: {
allowDefaultProject: ["*.config.*s", "bin/*.js", "script/*.ts"],
allowDefaultProject: ["*.config.*s", "bin/*.js"],
},
tsconfigRootDir: import.meta.dirname,
},
Expand Down
14 changes: 13 additions & 1 deletion script/__snapshots__/migrate-test-e2e.ts.snap
Original file line number Diff line number Diff line change
Expand Up @@ -174,7 +174,7 @@ exports[`expected file changes > eslint.config.js 1`] = `
languageOptions: {
parserOptions: {
- projectService: {
- allowDefaultProject: ["*.config.*s", "bin/*.js", "script/*.ts"],
- allowDefaultProject: ["*.config.*s", "bin/*.js"],
- },
+ projectService: { allowDefaultProject: ["*.config.*s"] },
tsconfigRootDir: import.meta.dirname,
Expand Down Expand Up @@ -232,3 +232,15 @@ exports[`expected file changes > knip.json 1`] = `
+ "project": ["src/**/*.ts!"]
}"
`;
exports[`expected file changes > tsconfig.json 1`] = `
"--- a/tsconfig.json
+++ b/tsconfig.json
@@ ... @@
"strict": true,
"target": "ES2022"
},
- "include": ["src", "script"]
+ "include": ["src"]
}"
`;
1 change: 1 addition & 0 deletions script/migrate-test-e2e.ts
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ const filesExpectedToBeChanged = [
".prettierignore",
"cspell.json",
"eslint.config.js",
"tsconfig.json",
];

const filesThatMightBeChanged = new Set([
Expand Down
2 changes: 1 addition & 1 deletion tsconfig.json
Original file line number Diff line number Diff line change
Expand Up @@ -12,5 +12,5 @@
"strict": true,
"target": "ES2022"
},
"include": ["src"]
"include": ["src", "script"]
}
Loading