Fixes #3597: InvalidCastException in FetchForWriting #3599
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ver a bug where an InvalidCastException is thrown when the aggregate is inline and UseIdentityMapForAggregates = true.
…ersion) would throw an InvalidCastException when the aggregate is inline and UseIdentityMapForAggregates = true.
|
@Strythio Thank you very much for doing this! The CI failures aren't related to your work (we have constant problems w/ blinking tests". This will be in 7.34.1 immediately |
|
Awesome! Glad I could help. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3597: InvalidCastException in FetchForWriting
This PR resolves #3597, where the
FetchForWriting<T>(the overload accepting an expected version) would throw anInvalidCastExceptionunder the following conditions:UseIdentityMapForAggregates = true.Changes Made
FetchInlinedPlan.cs.Testing
Notes
Guididentifier case. Many of the existing tests target bothGuidandstringidentifier aggregates. While my tests should cover the scenario effectively, I am happy to add tests for thestringvariants if needed. Let me know if this is required.StressTestsproject failed, but they fail for me with or without my changes.Feedback
This is my first pull request, and I am eager to learn! If any changes are needed, I will address them promptly. Any additional feedback on the implementation or testing strategy is also welcome.