Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set XHR response type to "text" when the request's Accept header is text/plain or application/json #1452

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Set XHR response type to "text" when the request's Accept header is text/plain or application/json #1452

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7a30ffe
set response type to 'text' if Accept header supports it
FrikkieSnyman Mar 13, 2024
5e3f235
Merge branch 'JakeChampion:main' into text-responsetype
FrikkieSnyman Apr 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion fetch.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -591,7 +591,9 @@ export function fetch(input, init) {
}

if ('responseType' in xhr) {
if (support.blob) {
if (request.headers.get("Accept") && (request.headers.get("Accept").indexOf("application/json") !== -1 || request.headers.get("Accept").indexOf("text/plain") !== -1)) {
xhr.responseType = 'text';
} else if (support.blob) {
xhr.responseType = 'blob'
} else if (
support.arrayBuffer
Expand Down