Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump mathlib #273

Merged
merged 4 commits into from
Dec 17, 2024
Merged

Conversation

YaelDillies
Copy link
Contributor

@YaelDillies YaelDillies commented Dec 8, 2024

Closes #271

Comment on lines +1 to +8
import Mathlib.FieldTheory.Separable
import Mathlib.NumberTheory.RamificationInertia.Basic
import Mathlib.RingTheory.DedekindDomain.FiniteAdeleRing
import Mathlib.RingTheory.DedekindDomain.IntegralClosure
import Mathlib.Topology.Algebra.Algebra
import Mathlib.Topology.Algebra.Module.ModuleTopology
import FLT.Mathlib.Algebra.Algebra.Subalgebra.Pi
import FLT.Mathlib.Algebra.Order.Hom.Monoid
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The algebra instance started timing out with import Mathlib

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:-(

Comment on lines +1 to +8
import Mathlib.FieldTheory.Separable
import Mathlib.NumberTheory.RamificationInertia.Basic
import Mathlib.RingTheory.DedekindDomain.FiniteAdeleRing
import Mathlib.RingTheory.DedekindDomain.IntegralClosure
import Mathlib.Topology.Algebra.Algebra
import Mathlib.Topology.Algebra.Module.ModuleTopology
import FLT.Mathlib.Algebra.Algebra.Subalgebra.Pi
import FLT.Mathlib.Algebra.Order.Hom.Monoid
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:-(

FLT/NumberField/AdeleRing.lean Outdated Show resolved Hide resolved
lake-manifest.json Show resolved Hide resolved
lake-manifest.json Show resolved Hide resolved
@kbuzzard
Copy link
Collaborator

kbuzzard commented Dec 9, 2024

What the heck does "uncaught exception: parser 'subscript' was not found" (when compiling some random analysis file in mathlib) mean?

Independent of that, are you happy @pitmonticone with the changes to lake-manifest.json?

@pitmonticone
Copy link
Collaborator

Independent of that, are you happy @pitmonticone with the changes to lake-manifest.json?

Yes, happy with those. I wasn't aware of that version pin and I don't think is justified, so I endorse the changes by Yaël.

@digama0
Copy link
Contributor

digama0 commented Dec 9, 2024

What the heck does "uncaught exception: parser 'subscript' was not found" (when compiling some random analysis file in mathlib) mean?

See https://leanprover.zulipchat.com/#narrow/channel/270676-lean4/topic/lean4checker.20failure/near/485826350 . Short version is that mathlib is currently borked and this will have to be fixed in mathlib and/or lean.

@kbuzzard
Copy link
Collaborator

Still "uncaught exception: parser 'subscript' was not found
". Do we just wait?

@digama0
Copy link
Contributor

digama0 commented Dec 11, 2024

The issue to watch is leanprover/lean4#6325

@kbuzzard kbuzzard merged commit 0986ffc into ImperialCollegeLondon:main Dec 17, 2024
2 checks passed
@YaelDillies YaelDillies deleted the bump_2024_12_08 branch December 17, 2024 23:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Updates available but manual intervention required
4 participants