Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implemented entities_metadata_statements() for SQLImplementation() #679

Merged
merged 13 commits into from
Nov 16, 2023
Merged

Implemented entities_metadata_statements() for SQLImplementation() #679

merged 13 commits into from
Nov 16, 2023

Conversation

hrshdhgd
Copy link
Collaborator

@hrshdhgd hrshdhgd commented Nov 14, 2023 •
edited
Loading

Fixes #676

@hrshdhgd hrshdhgd requested a review from cmungall November 14, 2023 23:08
@hrshdhgd hrshdhgd mentioned this pull request Nov 14, 2023
Open
@codecov-commenter
Copy link

codecov-commenter commented Nov 14, 2023 •
edited
Loading

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (823953c) 76.46% compared to head (076fd41) 76.48%.

Files Patch % Lines
...oaklib/implementations/sqldb/sql_implementation.py 94.11% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #679      +/-   ##
==========================================
+ Coverage   76.46%   76.48%   +0.01%     
==========================================
  Files         252      252              
  Lines       29356    29385      +29     
==========================================
+ Hits        22446    22474      +28     
- Misses       6910     6911       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hrshdhgd hrshdhgd requested a review from cmungall November 15, 2023 22:30
@hrshdhgd hrshdhgd merged commit c069273 into main Nov 16, 2023
5 checks passed
@hrshdhgd hrshdhgd deleted the issue-676 branch November 16, 2023 22:18
@joeflack4
Copy link
Contributor

Much thanks, @hrshdhgd

@hrshdhgd
Copy link
Collaborator Author

Thank you for bringing this up!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmungall cmungall cmungall approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Performance: SqlImplementation.entity_metadata_map()
4 participants
@hrshdhgd @codecov-commenter @joeflack4 @cmungall