-
Notifications
You must be signed in to change notification settings - Fork 588
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Require new-ish setuptools to build wheels #1177
Conversation
While still supporting a single source of truth for pinning.
Shouldn't all |
Also, with new-ish setuptools you can move all the metadata to setup.cfg. pyup bot got it support with latest release, so it should continue keep deps up-to-date. However, iirc, it couldn't manage setup.py itself. |
We still need something as inputs for |
Why do we need |
That fully pinned version means our CI builds are repeatable, including if we go back to an older version using now-outdated packages. This is also the target of our weekly updates from @pyup-bot, so we can see if our tests pass with new versions or fix things for upgraded linters. |
Closing this (and the issue) as wontfix - having done some more work, I just don't think correctness is worth the cost in compatibility with old versions at this time. |
Closes #1091. It looks like this actually works (at least in our CI)!
This PR also reorganises our input dependencies a bit, moving them to
setup.py
and adding minimum versions for most of them. I will probably move that to a separate pull as it's a bigger change than I expected - with the remaining piece to either fix or work around jazzband/pip-tools#204 (the-e .[...]
line converted to local absolute path). Fortunately I think we can just strip lines starting with-e
from our .txt outputs, so this is manageable.