Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Main #202007

Closed
wants to merge 14 commits into from
Closed

Main #202007

wants to merge 14 commits into from

Conversation

Space-Naught
Copy link

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

@github-actions github-actions bot added automerge-skip `brew pr-automerge` will skip this pull request new formula PR adds a new formula to Homebrew/homebrew-core labels Dec 21, 2024
Copy link
Contributor

Thanks for contributing to Homebrew! 🎉 It looks like you're having trouble with a CI failure. See our contribution guide for help. You may be most interested in the section on dealing with CI failures. You can find the CI logs in the Checks tab of your pull request.

@daeho-ro daeho-ro marked this pull request as draft December 21, 2024 04:46
@daeho-ro
Copy link
Member

daeho-ro commented Dec 21, 2024

Thank you for your submission, @Space-Naught . It seems that the formula is too much customized and we have many stanzas for that. Please take a look for the documentation, https://docs.brew.sh/Adding-Software-to-Homebrew#formulae .

desc "DeskThing for Mac - Manual SHA256 Formula"
homepage "https://github.com/ItsRiprod/TestThing"
version "0.10.76"
license "Proprietary"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, proprietary software is not allowed in the official core tap 1.

Footnotes

  1. https://docs.brew.sh/Acceptable-Formulae#we-dont-like-binary-formulae

@ZhongRuoyu ZhongRuoyu closed this Dec 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge-skip `brew pr-automerge` will skip this pull request new formula PR adds a new formula to Homebrew/homebrew-core
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants