Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tuist: deprecate #193538

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

tuist: deprecate #193538

wants to merge 2 commits into from

Conversation

fortmarek
Copy link

@fortmarek fortmarek commented Nov 28, 2024

We've already tried to remove this cask in the past: #180746

It causes issues for us as maintainers of Tuist. The cask was not added by a maintainer of Tuist and the maintainers have not approved of that: #145456. Additionally, as reasoned here, we don't think the cask should have been approved by the Homebrew team in the first place – even when not considering maintainers' (dis)approval

We much prefer to maintain our formulae and casks in our own repository: https://github.com/tuist/homebrew-tuist

Additionally, we added a cask for our new macOS app while this cask points to a CLI.

That means the only way for our users to download our official macOS cask, they have to run brew install --cask tuist/tuist/tuist – that is use the fully qualified name, instead of just running brew tap tuist/tuist && brew install --cask tuist.

We'd very much like to go forward with a deprecation period followed up with the removal of this cask.

If this is not an option, we'd need to change this cask to instead download our app, not the CLI. That, however, feels like a breaking change as brew install tuist will suddenly download something completely different.

Our clear preference is for removal of this cask, but if there is no other way, would the Homebrew team accept this cask to be changed to download an app binary instead of a CLI?

After making any changes to a cask, existing or new, verify:

Additionally, if adding a new cask:

  • Named the cask according to the token reference.
  • Checked the cask was not already refused (add your cask's name to the end of the search field).
  • brew audit --cask --new <cask> worked successfully.
  • HOMEBREW_NO_INSTALL_FROM_API=1 brew install --cask <cask> worked successfully.
  • brew uninstall --cask <cask> worked successfully.

@BrewTestBot BrewTestBot added the cask deprecated Cask deprecated label Nov 28, 2024
@khipp khipp added the awaiting maintainer feedback Issue needs response from a maintainer. label Nov 28, 2024
@MikeMcQuaid
Copy link
Member

If this is not an option, we'd need to change this cask to instead download our app, not the CLI. That, however, feels like a breaking change as brew install tuist will suddenly download something completely different.

Yup, this is what we’d be more likely to accept. Presumably the app can also install the CLI so that feels like a good middle ground.

@fortmarek
Copy link
Author

Presumably the app can also install the CLI so that feels like a good middle ground.

The CLI and app have different versions, so I'm not sure how that would work with the version value defined in the cask. I will update this PR to change the cask to point to the macOS app instead of deprecating it.

@MikeMcQuaid
Copy link
Member

Could the tuist CLI be a formula i.e. it's open source and can be built form source?

@daeho-ro daeho-ro changed the title Discontinue Tuist cask tuist: deprecate Nov 30, 2024
@BrewTestBot BrewTestBot added missing zap Cask is missing a zap stanza, please add one. and removed cask deprecated Cask deprecated labels Dec 2, 2024
@fortmarek
Copy link
Author

Could the tuist CLI be a formula i.e. it's open source and can be built form source?

There's a tiny bit of the CLI that's closed source, which we hope to change in the future. We do have a formula for it in our own repo: https://github.com/tuist/homebrew-tuist/tree/main/Formula.

I updated the cask to be our macOS app instead.

@MikeMcQuaid
Copy link
Member

@fortmarek Does this cask also install the CLI? If not, I'm inclined to say this should be a new Cask called tuist-app or something to avoid breaking the workflows of the existing folks, at least until homebrew-core can get an open-source tuist formula.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting maintainer feedback Issue needs response from a maintainer. missing zap Cask is missing a zap stanza, please add one.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants