(Partly) stop background apps taking focus from the terminal #498
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This slightly helps with HeyPuter#453.
This is a bit of a temporary hack for HeyPuter#453, and only partly effective.
Long-term we probably want a WindowService instead.
Merged
|
This is pretty deep in gui logic for something that doesn't work 100% of the time; I don't understand the full ramifications of this so I'll need @jelveh 's input. I think this should probably be fixed properly without any intermediate fixes. (i.e. background apps shouldn't go on the window stack, as you mentioned) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a slightly hacky solution which doesn't work 100% of the time, but it's a lot nicer to use the terminal with git with these changes. (Previously, the terminal would lose focus after every git command which gets annoying fast.)
What stops this being a full fix is that the windowing code doesn't know if a window is a background window or not. They still go into the
window_stack, and so when a window closes (likegit's) it focuses the next window on the stack, and if that'sphoenixthen the terminal loses focus.I started playing with a Service for managing windows, but that's a much bigger task and I didn't want to get too distracted. 😅 I think that can be a lot neater though.