Skip to content

Commit

Permalink
Close OpenRCT2#19782: Game stops counting inversions after 31
Browse files Browse the repository at this point in the history
  • Loading branch information
@Gymnasiast
Gymnasiast committed Sep 15, 2024
1 parent 2b36d59 commit aa06f79
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 1 deletion.
1 change: 1 addition & 0 deletions distribution/changelog.txt
View file
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
- Change: [#22740] Add virtual floor to shifted track design placement.
- Fix: [#2614] The colour tab of the ride window does not hide invisible cars (original bug).
- Fix: [#15406] Tunnels on steep Side-Friction track are drawn too low.
- Fix: [#19782] Game stops counting inversions after 31.
- Fix: [#21959] “Save this before...?” message does not appear when selecting “New Game”.
- Fix: [#22231] Invalid object version can cause a crash.
- Fix: [#22653] Add several .parkpatch files for missing water tiles in RCT1 and RCT2 scenarios.
Expand Down
2 changes: 1 addition & 1 deletion src/openrct2/Limits.h
View file
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ namespace OpenRCT2::Limits
constexpr uint8_t kCustomerHistorySize = RCT12::Limits::kCustomerHistorySize;
constexpr uint16_t kMaxGolfHoles = RCT12::Limits::kMaxGolfHoles;
constexpr uint16_t kMaxHelices = RCT12::Limits::kMaxHelices;
constexpr uint16_t kMaxInversions = RCT12::Limits::kMaxInversions;
constexpr uint16_t kMaxInversions = std::numeric_limits<uint16_t>::max();

Check failure on line 20 in src/openrct2/Limits.h

View workflow job for this annotation

GitHub Actions / macOS (x64) using CMake 

no member named 'numeric_limits' in namespace 'std'

Check failure on line 20 in src/openrct2/Limits.h

View workflow job for this annotation

GitHub Actions / macOS (x64) using CMake 

unexpected type name 'uint16_t': expected expression

Check failure on line 20 in src/openrct2/Limits.h

View workflow job for this annotation

GitHub Actions / macOS (x64) using CMake 

no member named 'max' in the global namespace

Check failure on line 20 in src/openrct2/Limits.h

View workflow job for this annotation

GitHub Actions / macOS (x64) using CMake 

no member named 'numeric_limits' in namespace 'std'

Check failure on line 20 in src/openrct2/Limits.h

View workflow job for this annotation

GitHub Actions / macOS (x64) using CMake 

unexpected type name 'uint16_t': expected expression

Check failure on line 20 in src/openrct2/Limits.h

View workflow job for this annotation

GitHub Actions / macOS (x64) using CMake 

no member named 'max' in the global namespace

Check failure on line 20 in src/openrct2/Limits.h

View workflow job for this annotation

GitHub Actions / macOS (x64) using CMake 

no member named 'numeric_limits' in namespace 'std'

Check failure on line 20 in src/openrct2/Limits.h

View workflow job for this annotation

GitHub Actions / macOS (x64) using CMake 

unexpected type name 'uint16_t': expected expression

Check failure on line 20 in src/openrct2/Limits.h

View workflow job for this annotation

GitHub Actions / macOS (x64) using CMake 

no member named 'max' in the global namespace

Check failure on line 20 in src/openrct2/Limits.h

View workflow job for this annotation

GitHub Actions / macOS (x64) using CMake 

no member named 'numeric_limits' in namespace 'std'

Check failure on line 20 in src/openrct2/Limits.h

View workflow job for this annotation

GitHub Actions / macOS (arm64) using CMake 

no member named 'numeric_limits' in namespace 'std'

Check failure on line 20 in src/openrct2/Limits.h

View workflow job for this annotation

GitHub Actions / macOS (arm64) using CMake 

unexpected type name 'uint16_t': expected expression

Check failure on line 20 in src/openrct2/Limits.h

View workflow job for this annotation

GitHub Actions / macOS (arm64) using CMake 

no member named 'max' in the global namespace

Check failure on line 20 in src/openrct2/Limits.h

View workflow job for this annotation

GitHub Actions / macOS (arm64) using CMake 

no member named 'numeric_limits' in namespace 'std'

Check failure on line 20 in src/openrct2/Limits.h

View workflow job for this annotation

GitHub Actions / macOS (arm64) using CMake 

unexpected type name 'uint16_t': expected expression

Check failure on line 20 in src/openrct2/Limits.h

View workflow job for this annotation

GitHub Actions / macOS (arm64) using CMake 

no member named 'max' in the global namespace

Check failure on line 20 in src/openrct2/Limits.h

View workflow job for this annotation

GitHub Actions / macOS (arm64) using CMake 

no member named 'numeric_limits' in namespace 'std'

Check failure on line 20 in src/openrct2/Limits.h

View workflow job for this annotation

GitHub Actions / macOS (arm64) using CMake 

unexpected type name 'uint16_t': expected expression

Check failure on line 20 in src/openrct2/Limits.h

View workflow job for this annotation

GitHub Actions / macOS (arm64) using CMake 

no member named 'max' in the global namespace

Check failure on line 20 in src/openrct2/Limits.h

View workflow job for this annotation

GitHub Actions / macOS (arm64) using CMake 

no member named 'numeric_limits' in namespace 'std'

Check failure on line 20 in src/openrct2/Limits.h

View workflow job for this annotation

GitHub Actions / Windows (win32) using mingw 

‘numeric_limits’ is not a member of ‘std’

Check failure on line 20 in src/openrct2/Limits.h

View workflow job for this annotation

GitHub Actions / Windows (win32) using mingw 

expected primary-expression before ‘>’ token

Check failure on line 20 in src/openrct2/Limits.h

View workflow job for this annotation

GitHub Actions / Windows (win32) using mingw 

‘::max’ has not been declared

Check failure on line 20 in src/openrct2/Limits.h

View workflow job for this annotation

GitHub Actions / Windows (win32) using mingw 

‘numeric_limits’ is not a member of ‘std’

Check failure on line 20 in src/openrct2/Limits.h

View workflow job for this annotation

GitHub Actions / Windows (win32) using mingw 

expected primary-expression before ‘>’ token

Check failure on line 20 in src/openrct2/Limits.h

View workflow job for this annotation

GitHub Actions / Windows (win32) using mingw 

‘::max’ has not been declared

Check failure on line 20 in src/openrct2/Limits.h

View workflow job for this annotation

GitHub Actions / Windows (win32) using mingw 

incomplete type ‘std::numeric_limits<short unsigned int>’ used in nested name specifier

Check failure on line 20 in src/openrct2/Limits.h

View workflow job for this annotation

GitHub Actions / Windows (win32) using mingw 

‘numeric_limits’ is not a member of ‘std’

Check failure on line 20 in src/openrct2/Limits.h

View workflow job for this annotation

GitHub Actions / Windows (win32) using mingw 

expected primary-expression before ‘>’ token

Check failure on line 20 in src/openrct2/Limits.h

View workflow job for this annotation

GitHub Actions / Windows (win32) using mingw 

‘::max’ has not been declared

Check failure on line 20 in src/openrct2/Limits.h

View workflow job for this annotation

GitHub Actions / Debian Linux (bookworm, x86_64, portable) 

'numeric_limits' is not a member of 'std'

Check failure on line 20 in src/openrct2/Limits.h

View workflow job for this annotation

GitHub Actions / Debian Linux (bookworm, x86_64, portable) 

expected primary-expression before '>' token

Check failure on line 20 in src/openrct2/Limits.h

View workflow job for this annotation

GitHub Actions / Debian Linux (bookworm, x86_64, portable) 

'::max' has not been declared

Check failure on line 20 in src/openrct2/Limits.h

View workflow job for this annotation

GitHub Actions / Debian Linux (bookworm, x86_64, portable) 

'numeric_limits' is not a member of 'std'

Check failure on line 20 in src/openrct2/Limits.h

View workflow job for this annotation

GitHub Actions / Debian Linux (bookworm, x86_64, portable) 

expected primary-expression before '>' token

Check failure on line 20 in src/openrct2/Limits.h

View workflow job for this annotation

GitHub Actions / Debian Linux (bookworm, x86_64, portable) 

'::max' has not been declared

Check failure on line 20 in src/openrct2/Limits.h

View workflow job for this annotation

GitHub Actions / Debian Linux (bookworm, x86_64, portable) 

incomplete type 'std::numeric_limits<short unsigned int>' used in nested name specifier

Check failure on line 20 in src/openrct2/Limits.h

View workflow job for this annotation

GitHub Actions / Debian Linux (bookworm, x86_64, portable) 

'numeric_limits' is not a member of 'std'

Check failure on line 20 in src/openrct2/Limits.h

View workflow job for this annotation

GitHub Actions / Debian Linux (bookworm, x86_64, portable) 

expected primary-expression before '>' token

Check failure on line 20 in src/openrct2/Limits.h

View workflow job for this annotation

GitHub Actions / Debian Linux (bookworm, x86_64, portable) 

'::max' has not been declared

Check failure on line 20 in src/openrct2/Limits.h

View workflow job for this annotation

GitHub Actions / Ubuntu Linux (noble, x86_64, portable) 

'numeric_limits' is not a member of 'std'

Check failure on line 20 in src/openrct2/Limits.h

View workflow job for this annotation

GitHub Actions / Ubuntu Linux (noble, x86_64, portable) 

expected primary-expression before '>' token

Check failure on line 20 in src/openrct2/Limits.h

View workflow job for this annotation

GitHub Actions / Ubuntu Linux (noble, x86_64, portable) 

'::max' has not been declared

Check failure on line 20 in src/openrct2/Limits.h

View workflow job for this annotation

GitHub Actions / Ubuntu Linux (noble, x86_64, portable) 

'numeric_limits' is not a member of 'std'

Check failure on line 20 in src/openrct2/Limits.h

View workflow job for this annotation

GitHub Actions / Ubuntu Linux (noble, x86_64, portable) 

expected primary-expression before '>' token

Check failure on line 20 in src/openrct2/Limits.h

View workflow job for this annotation

GitHub Actions / Ubuntu Linux (noble, x86_64, portable) 

'::max' has not been declared

Check failure on line 20 in src/openrct2/Limits.h

View workflow job for this annotation

GitHub Actions / Ubuntu Linux (noble, x86_64, portable) 

incomplete type 'std::numeric_limits<short unsigned int>' used in nested name specifier

Check failure on line 20 in src/openrct2/Limits.h

View workflow job for this annotation

GitHub Actions / Ubuntu Linux (noble, x86_64, portable) 

'numeric_limits' is not a member of 'std'

Check failure on line 20 in src/openrct2/Limits.h

View workflow job for this annotation

GitHub Actions / Ubuntu Linux (noble, x86_64, portable) 

expected primary-expression before '>' token

Check failure on line 20 in src/openrct2/Limits.h

View workflow job for this annotation

GitHub Actions / Ubuntu Linux (noble, x86_64, portable) 

'::max' has not been declared

Check failure on line 20 in src/openrct2/Limits.h

View workflow job for this annotation

GitHub Actions / Ubuntu Linux (noble, debug, [http, network, flac, vorbis OpenGL] disabled) using clang 

no member named 'numeric_limits' in namespace 'std'

Check failure on line 20 in src/openrct2/Limits.h

View workflow job for this annotation

GitHub Actions / Ubuntu Linux (noble, debug, [http, network, flac, vorbis OpenGL] disabled) using clang 

unexpected type name 'uint16_t': expected expression

Check failure on line 20 in src/openrct2/Limits.h

View workflow job for this annotation

GitHub Actions / Ubuntu Linux (noble, debug, [http, network, flac, vorbis OpenGL] disabled) using clang 

no member named 'max' in the global namespace

Check failure on line 20 in src/openrct2/Limits.h

View workflow job for this annotation

GitHub Actions / Ubuntu Linux (noble, debug, [http, network, flac, vorbis OpenGL] disabled) using clang 

no member named 'numeric_limits' in namespace 'std'

Check failure on line 20 in src/openrct2/Limits.h

View workflow job for this annotation

GitHub Actions / Ubuntu Linux (noble, debug, [http, network, flac, vorbis OpenGL] disabled) using clang 

unexpected type name 'uint16_t': expected expression

Check failure on line 20 in src/openrct2/Limits.h

View workflow job for this annotation

GitHub Actions / Ubuntu Linux (noble, debug, [http, network, flac, vorbis OpenGL] disabled) using clang 

no member named 'max' in the global namespace

Check failure on line 20 in src/openrct2/Limits.h

View workflow job for this annotation

GitHub Actions / Ubuntu Linux (noble, debug, [http, network, flac, vorbis OpenGL] disabled) using clang 

implicit instantiation of undefined template 'std::numeric_limits<unsigned short>'

Check failure on line 20 in src/openrct2/Limits.h

View workflow job for this annotation

GitHub Actions / Ubuntu Linux (noble, debug, [http, network, flac, vorbis OpenGL] disabled) using clang 

no member named 'numeric_limits' in namespace 'std'

Check failure on line 20 in src/openrct2/Limits.h

View workflow job for this annotation

GitHub Actions / Ubuntu Linux (noble, debug, [http, network, flac, vorbis OpenGL] disabled) using clang 

unexpected type name 'uint16_t': expected expression

Check failure on line 20 in src/openrct2/Limits.h

View workflow job for this annotation

GitHub Actions / Ubuntu Linux (noble, debug, [http, network, flac, vorbis OpenGL] disabled) using clang 

no member named 'max' in the global namespace

Check failure on line 20 in src/openrct2/Limits.h

View workflow job for this annotation

GitHub Actions / Ubuntu Linux (debug) using clang, coverage enabled 

no member named 'numeric_limits' in namespace 'std'

Check failure on line 20 in src/openrct2/Limits.h

View workflow job for this annotation

GitHub Actions / Ubuntu Linux (debug) using clang, coverage enabled 

unexpected type name 'uint16_t': expected expression

Check failure on line 20 in src/openrct2/Limits.h

View workflow job for this annotation

GitHub Actions / Ubuntu Linux (debug) using clang, coverage enabled 

no member named 'max' in the global namespace

Check failure on line 20 in src/openrct2/Limits.h

View workflow job for this annotation

GitHub Actions / Ubuntu Linux (debug) using clang, coverage enabled 

no member named 'numeric_limits' in namespace 'std'

Check failure on line 20 in src/openrct2/Limits.h

View workflow job for this annotation

GitHub Actions / Ubuntu Linux (debug) using clang, coverage enabled 

unexpected type name 'uint16_t': expected expression

Check failure on line 20 in src/openrct2/Limits.h

View workflow job for this annotation

GitHub Actions / Ubuntu Linux (debug) using clang, coverage enabled 

no member named 'max' in the global namespace

Check failure on line 20 in src/openrct2/Limits.h

View workflow job for this annotation

GitHub Actions / Ubuntu Linux (debug) using clang, coverage enabled 

implicit instantiation of undefined template 'std::numeric_limits<unsigned short>'

Check failure on line 20 in src/openrct2/Limits.h

View workflow job for this annotation

GitHub Actions / Ubuntu Linux (debug) using clang, coverage enabled 

no member named 'numeric_limits' in namespace 'std'

Check failure on line 20 in src/openrct2/Limits.h

View workflow job for this annotation

GitHub Actions / Ubuntu Linux (debug) using clang, coverage enabled 

unexpected type name 'uint16_t': expected expression

Check failure on line 20 in src/openrct2/Limits.h

View workflow job for this annotation

GitHub Actions / Ubuntu Linux (debug) using clang, coverage enabled 

no member named 'max' in the global namespace
constexpr uint16_t kMaxTrainsPerRide = 255;
constexpr uint16_t kMaxCarsPerTrain = 255;
constexpr const uint16_t kMaxVehicleColours = kMaxTrainsPerRide; // this should really be kMaxTrainsPerRide *
Expand Down

0 comments on commit aa06f79

Please sign in to comment.