Worked on sample #5257
Worked on sample #5257
Conversation
|
Hi Harneet sorry we got cut off: |
There was a problem hiding this comment.
It would be helpful to add a unit test. To do so, I recommend:
- factor out the parsing into a new function. i.e.
def ParseOutput(stdout):
samples = []
...
return samples
Your unit test should be a new file in https://github.com/GoogleCloudPlatform/PerfKitBenchmarker/tree/master/tests/linux_benchmarks called cryptsetup_test.py
In this file, you should include the expected output as a string, and call your parse function.
See https://github.com/GoogleCloudPlatform/PerfKitBenchmarker/blob/master/tests/linux_benchmarks/cassandra_stress_benchmark_test.py for an example.
This would be great, but I think it could be a follow-up PR. |
| list = line.split() | ||
| metric = list[0] | ||
| iteration = list[1] | ||
| unit = ''.join(list[2:4]) |
There was a problem hiding this comment.
I think this needs to be [2:5], because the second one is inclusive.
We also want ' '.join to not have "iterationspersecond" smooshed together.
| metric = list[0] | ||
| iteration = list[1] | ||
| unit = ''.join(list[2:4]) | ||
| metadata = list[6] |
There was a problem hiding this comment.
Oh and this needs to be a dictionary.
Something like:
metadata = {'key_size': list[6]}
| line = stdout.splitlines() | ||
| line = line[1:5] | ||
| for line in stdout: | ||
| list = line.split() |
There was a problem hiding this comment.
could this be renamed to words or something besides list to avoid colliding with the python builtin list?
|
I'll tweak this and merge it. |
Worked with creating a loop to get the data for sample object